Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Image Pull Policy configurable via Helm value #721

Closed
3 tasks
RealAnna opened this issue Jan 30, 2023 · 1 comment · Fixed by #740
Closed
3 tasks

Make Image Pull Policy configurable via Helm value #721

RealAnna opened this issue Jan 30, 2023 · 1 comment · Fixed by #740
Assignees
@sudiptob2
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@RealAnna
Copy link
Contributor

RealAnna commented Jan 30, 2023 •
edited
Loading

For each containers in our k8s resources definitions, we should substitute the imagePullPolicy with an helm value (like it was done for otelCollector.url ) that defaults to Always.

DoD

  • value file contains a new value imagePullPolicy
  • the value is patched to all the deployments in our helm overlay (modify this )
  • default value set to Always
@RealAnna RealAnna added the good first issue Good for newcomers label Jan 30, 2023
@RealAnna RealAnna mentioned this issue Jan 30, 2023
Merged
12 tasks
@thisthat thisthat added the enhancement New feature or request label Jan 30, 2023
@thisthat thisthat mentioned this issue Jan 31, 2023
Closed
1 task
@sudiptob2
Copy link
Member

I think this issue is similar to #724 I can work on this issue also as #724 is already assigned to me. Please assign

sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue Feb 1, 2023
@sudiptob2
feat:new value imagePullPolicy added (keptn#721)
4187ec3 
Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>
@sudiptob2 sudiptob2 mentioned this issue Feb 1, 2023
Merged
5 tasks
sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue Feb 1, 2023
@sudiptob2
feat: imagePullPolicy is added in the overlay (keptn#721)
e9d8fc3 
Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>
sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue Feb 2, 2023
@sudiptob2
feat: cert manager portion uncommented (keptn#721)
23f07fd 
Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>
sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue Feb 2, 2023
@sudiptob2
feat:new value imagePullPolicy added (keptn#721)
f7e459d 
Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>
sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue Feb 2, 2023
@sudiptob2
feat: imagePullPolicy is added in the overlay (keptn#721)
9ad727a 
Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>
sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue Feb 2, 2023
@sudiptob2
feat: cert manager portion uncommented (keptn#721)
4fe4c35 
Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>
sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue Feb 2, 2023
@sudiptob2
feat: readme-generator-for-helm added in gitignore (keptn#721)
8c47430 
Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>
sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue Feb 2, 2023
@sudiptob2
feat: regenerated helm chart docs (keptn#721)
3882974 
Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>
sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue Feb 2, 2023
@sudiptob2
feat: nit, added newline in the end of gitignore (keptn#721)
b5864a5 
Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>
sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue Feb 2, 2023
@sudiptob2
feat: irrelevant comment removed (keptn#721)
c3c6583 
Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>
sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue Feb 2, 2023
@sudiptob2
feat: removed qoutes around helm template syntax (keptn#721)
bfeafec 
Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sudiptob2 sudiptob2

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: configurable imagePullPolicy via Helm sudiptob2/lifecycle-toolkit
3 participants
@thisthat @sudiptob2 @RealAnna