Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong path to the observability folder in the sample app Makefile #779

Closed
sudiptob2 opened this issue Feb 7, 2023 · 0 comments · Fixed by #780
Closed

Wrong path to the observability folder in the sample app Makefile #779

sudiptob2 opened this issue Feb 7, 2023 · 0 comments · Fixed by #780

Comments

@sudiptob2
Copy link
Member

sudiptob2 commented Feb 7, 2023 •
edited
Loading

The sample app Makefile(lifecycle-toolkit/example/sample-app/Makefile) has wrong reference to the observability folder.
Currently observability folder is under support folder.
As a result make install command don't work.

Ref:

lifecycle-toolkit/examples/sample-app/Makefile

Line 9 in f2263b5

make -C ../observability install

sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue Feb 7, 2023
@sudiptob2
fix: updated path to observability folder (keptn#779)
ac74364 
Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>
sudiptob2 added a commit to sudiptob2/lifecycle-toolkit that referenced this issue Feb 7, 2023
@sudiptob2
fix: updated path to observability folder for uninstall command (kept…
9625261 
…n#779)

Signed-off-by: Sudipto Baral <sudiptobaral.me@gmail.com>
@sudiptob2 sudiptob2 mentioned this issue Feb 7, 2023
Merged
thisthat pushed a commit that referenced this issue Feb 7, 2023
@sudiptob2
fix: updated path to observability folder (#780)
f2f09ea 
Fixes #779
@sudiptob2 sudiptob2 mentioned this issue Jan 24, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: updated path to observability folder sudiptob2/lifecycle-toolkit
1 participant
@sudiptob2