Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numpy bincount docstrings #655

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

dranaivo
Copy link
Contributor

@dranaivo dranaivo commented Aug 1, 2023

Related to keras-team/keras#18442.

Added a docstring to keras_core.ops.bincount / keras_core.ops.numpy.bincount.

@google-cla
Copy link

google-cla bot commented Aug 1, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

keras_core/ops/numpy.py Outdated Show resolved Hide resolved
keras_core/ops/numpy.py Outdated Show resolved Hide resolved
keras_core/ops/numpy.py Outdated Show resolved Hide resolved
keras_core/ops/numpy.py Outdated Show resolved Hide resolved
keras_core/ops/numpy.py Outdated Show resolved Hide resolved
@dranaivo dranaivo changed the title Numpy bincount docstrings Add numpy bincount docstrings Aug 2, 2023
@dranaivo dranaivo requested a review from fchollet August 2, 2023 16:33
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@fchollet fchollet merged commit 44a1d21 into keras-team:main Aug 2, 2023
6 checks passed
@dranaivo dranaivo deleted the numpy-bincount-docstrings branch August 2, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants