Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bounding_box.converters.convert_format #1596

Merged

Conversation

james77777778
Copy link
Contributor

@james77777778 james77777778 commented Mar 28, 2023

What does this PR do?

Fixes #1572

This PR fixes the bug in unit tests as well as _image_shape in converters.

A new unit test called test_dense_bounding_box_with_ragged_images has been added to validate inputs with ragged images and dense bounding_boxes, which were causing error as mentioned in #1537 (comment)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you write any new necessary tests?
  • If this adds a new model, can you run a few training steps on TPU in Colab to ensure that no XLA incompatible OP are used?

Who can review?

@LukeWood @ianstenbit

@james77777778 james77777778 changed the title Fix bounding_box.converter Fix bounding_box.converters.convert_format Mar 28, 2023
Copy link
Contributor

@LukeWood LukeWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @james77777778

@LukeWood
Copy link
Contributor

/gcbrun

@LukeWood LukeWood merged commit a630e2b into keras-team:master Mar 28, 2023
@james77777778 james77777778 deleted the fix-bounding-box-converter branch March 29, 2023 00:54
ghost pushed a commit to y-vectorfield/keras-cv that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in bounding_box.converts._xyxy_to_rel_xyxy:
2 participants