-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding deeplab_v3_plus_presets #2051
Conversation
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Divya! Looks good, just a few little tweaks.
keras_cv/models/segmentation/deeplab_v3_plus/deeplab_v3_plus_presets.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a quick question about the preset bit -- @jbischof curious about your take as well. (IMO we should make this from_preset
change on the Task
class instead of just for DeepLabV3Plus
keras_cv/models/segmentation/deeplab_v3_plus/deeplab_v3_plus.py
Outdated
Show resolved
Hide resolved
keras_cv/models/segmentation/deeplab_v3_plus/deeplab_v3_plus_test.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- @jbischof PTAL quickly to verify that you're cool with this change to from_preset
/gcbrun |
keras_cv/models/segmentation/deeplab_v3_plus/deeplab_v3_plus_test.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks look amazing!
/gcbrun |
2 similar comments
/gcbrun |
/gcbrun |
keras_cv/models/segmentation/deeplab_v3_plus/deeplab_v3_plus_test.py
Outdated
Show resolved
Hide resolved
/gcbrun |
/gcbrun |
@divyashreepathihalli |
/gcbrun |
/gcbrun |
* adding deeplab_v3_plus_presets * update formatting * fixed error * reformatted * fix errors * added num_classses arg * add input_shape arg * update test * update input_shape * updated preset * update test * move update to from_preset to task.py * reformatted code * updated doc string * Update assert * Update deeplab_v3_plus_test.py test * Update task.py * Update deeplab_v3_plus_test.py * Update deeplab_v3_plus_test.py
* adding deeplab_v3_plus_presets * update formatting * fixed error * reformatted * fix errors * added num_classses arg * add input_shape arg * update test * update input_shape * updated preset * update test * move update to from_preset to task.py * reformatted code * updated doc string * Update assert * Update deeplab_v3_plus_test.py test * Update task.py * Update deeplab_v3_plus_test.py * Update deeplab_v3_plus_test.py
No description provided.