Fix publish to pypi action #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In keras-team#1124, I accidentally added a line doing a `pip install .` package install to the publish flow. This is silly, we shouldn't need to be installing the package before building the package for pypi, and it appears to be causing failures on the action: https://github.com/keras-team/keras-nlp/actions/runs/5513665846/jobs/10052068366 These were not caught because we don't run the pypi action on each PR.
jbischof
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1124, I accidentally added a line doing a
pip install .package install to the publish flow.This is silly, we shouldn't need to be installing the package before building the package for pypi, and it appears to be causing failures on the action:
https://github.com/keras-team/keras-nlp/actions/runs/5513665846/jobs/10052068366
These were not caught because we don't run the pypi action on each PR.