Add GitHub Action for Nightly #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampathweb
commented
Nov 9, 2023
pip_build.py
Outdated
| @@ -45,14 +46,36 @@ | |||
| ] | |||
|
|
|||
|
|
|||
| def build(): | |||
| def export_version_string(version, is_nightly=False, rc_index=None): | |||
There was a problem hiding this comment.
Copied from keras repo pip_build.py
mattdangerw
approved these changes
Nov 10, 2023
|
Oh also I think the |
Fixed it and also tested locally. |
mattdangerw
approved these changes
Nov 10, 2023
mattdangerw
added a commit
to mattdangerw/keras-hub
that referenced
this pull request
Nov 10, 2023
It has been failing since keras-team#1309, see https://github.com/keras-team/keras-nlp/actions/runs/6819858177/job/18547841938 I believe what is happening is that newly pinned nightly only had linux wheels for 3.9. And our publish to pypi flow did not specify the python version. https://pypi.org/project/tensorflow-text-nightly/2.16.0.dev20231107/#files Doing a few things here: - Updating the pinned package to a version where tensorflow-text-nightly has support for python 3.9, 3.10, and 3.11 on linux. - Fixing out publish to pypi workflow to set the python version like other workflow versions. - Some other cleanups for consistency with our github actions.
mattdangerw
added a commit
that referenced
this pull request
Nov 10, 2023
It has been failing since #1309, see https://github.com/keras-team/keras-nlp/actions/runs/6819858177/job/18547841938 I believe what is happening is that newly pinned nightly only had linux wheels for 3.9. And our publish to pypi flow did not specify the python version. https://pypi.org/project/tensorflow-text-nightly/2.16.0.dev20231107/#files Doing a few things here: - Updating the pinned package to a version where tensorflow-text-nightly has support for python 3.9, 3.10, and 3.11 on linux. - Fixing out publish to pypi workflow to set the python version like other workflow versions. - Some other cleanups for consistency with our github actions.
mattdangerw
pushed a commit
to mattdangerw/keras-hub
that referenced
this pull request
Dec 7, 2023
* Add GitHub Action for Nightly * Add GitHub Action for Nightly * Add GitHub Action for Nightly * Move tf-nightly pin to 11/4 * Move tf-nightly pin to 11/7
mattdangerw
added a commit
to mattdangerw/keras-hub
that referenced
this pull request
Dec 7, 2023
It has been failing since keras-team#1309, see https://github.com/keras-team/keras-nlp/actions/runs/6819858177/job/18547841938 I believe what is happening is that newly pinned nightly only had linux wheels for 3.9. And our publish to pypi flow did not specify the python version. https://pypi.org/project/tensorflow-text-nightly/2.16.0.dev20231107/#files Doing a few things here: - Updating the pinned package to a version where tensorflow-text-nightly has support for python 3.9, 3.10, and 3.11 on linux. - Fixing out publish to pypi workflow to set the python version like other workflow versions. - Some other cleanups for consistency with our github actions.
mattdangerw
pushed a commit
to mattdangerw/keras-hub
that referenced
this pull request
Dec 7, 2023
* Add GitHub Action for Nightly * Add GitHub Action for Nightly * Add GitHub Action for Nightly * Move tf-nightly pin to 11/4 * Move tf-nightly pin to 11/7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.