Add in-place modification of _token_embedding weights key for Keras 2 compatibility #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdangerw
pushed a commit
to mattdangerw/keras-hub
that referenced
this pull request
Dec 26, 2023
mattdangerw
pushed a commit
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a backwards compatibility issue with Keras 2 following the Kaggle integration.
Weights loaded in Keras 2 from Kaggle were originally saved in Keras 3, and the Keras 2 weights traversal order is the opposite of Keras 3.
This caused the
_token_embeddingattribute (where the weights were saved) to be ignored, since the publictoken_embeddingattribute comes in reverse order first.