-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix task pre-processor in tasks #1373
Fix task pre-processor in tasks #1373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Couple comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the fix Ramesh!
* Allow custom preprocessor * Allow custom preprocessor * Fix preprocessor validation in tasks
When a user passes
preprocessor
to afrom_preset
constructor via kwargs, it fails with "got multiple values for keyword argument 'preprocessor'". This is becausefrom_preset
addspreprocessor
parameter regardless of whether has also provided it. With this fix, we only add thepreprocessor
when the user has not provided the input.Also, adds a validation to verify that user doesn't provide a
backbone
to thefrom_preset
method since that's obtained from the preset directly.