Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - Add kaggle creds to pull model #1459

Merged
merged 11 commits into from
Mar 4, 2024

Conversation

sampathweb
Copy link
Collaborator

@sampathweb sampathweb commented Feb 22, 2024

keras_nlp/models/gemma/gemma_backbone_test.py::GemmaBackboneTest::test_smallest_preset - Failing on OOM.
Marked the test as extra_large so GPU CI passes.

@sampathweb sampathweb added the kokoro:force-run Runs Tests on GPU label Feb 22, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Feb 22, 2024
@sampathweb sampathweb added the kokoro:force-run Runs Tests on GPU label Feb 22, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Feb 22, 2024
@sampathweb sampathweb added the kokoro:force-run Runs Tests on GPU label Feb 23, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Feb 23, 2024
@sampathweb sampathweb added the kokoro:force-run Runs Tests on GPU label Feb 23, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Feb 23, 2024
@sampathweb sampathweb added the kokoro:force-run Runs Tests on GPU label Feb 23, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Feb 23, 2024
@sampathweb sampathweb added the kokoro:force-run Runs Tests on GPU label Feb 23, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Feb 23, 2024
@sampathweb sampathweb added the kokoro:force-run Runs Tests on GPU label Feb 23, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Feb 23, 2024
@sampathweb sampathweb added the kokoro:force-run Runs Tests on GPU label Feb 23, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Feb 23, 2024
@sampathweb sampathweb added the kokoro:force-run Runs Tests on GPU label Feb 26, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Feb 26, 2024
@sampathweb sampathweb added the kokoro:force-run Runs Tests on GPU label Feb 26, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Feb 26, 2024
mattdangerw added a commit to mattdangerw/keras-hub that referenced this pull request Feb 26, 2024
We can skip these by default, for users who have not yet set them up.
We will need to set them up for CI, see
keras-team#1459
mattdangerw added a commit that referenced this pull request Feb 27, 2024
We can skip these by default, for users who have not yet set them up.
We will need to set them up for CI, see
#1459
@sampathweb sampathweb added the kokoro:force-run Runs Tests on GPU label Mar 1, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Mar 1, 2024
@sampathweb sampathweb added the kokoro:force-run Runs Tests on GPU label Mar 1, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Mar 1, 2024
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

def test_smallest_preset(self):
# TODO: Fails with OOM on current GPU CI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option would be to take in a dtype to run_preset_test and pass is it as kwarg to from_preset. Then we could try bfloat16 precision, which might avoid the oom?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried keras.config.set_floatx("float16"), but that didn't help. So going to land this PR now. We can address it in another PR

@sampathweb sampathweb added the kokoro:force-run Runs Tests on GPU label Mar 4, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Mar 4, 2024
@sampathweb sampathweb merged commit a5e832c into keras-team:master Mar 4, 2024
6 checks passed
@sampathweb sampathweb deleted the ci-add-kaggle-env-var branch March 4, 2024 20:25
abuelnasr0 pushed a commit to abuelnasr0/keras-nlp that referenced this pull request Apr 2, 2024
We can skip these by default, for users who have not yet set them up.
We will need to set them up for CI, see
keras-team#1459
abuelnasr0 pushed a commit to abuelnasr0/keras-nlp that referenced this pull request Apr 2, 2024
* CI - Add kaggle creds to pull model

* add kaggle env variables

* Kaggle env:

* Kaggle env:

* Kaggle env:

* Kaggle env:

* Update Build script for Kokoro

* Add Kaggle env var

* set gemma preset to extra_large

* Change Gemma small preset to bfloat16

* Change Gemma small preset to xlarge
bestalternativereviews4 added a commit to bestalternativereviews4/keras-nlp that referenced this pull request Aug 14, 2024
We can skip these by default, for users who have not yet set them up.
We will need to set them up for CI, see
keras-team/keras-hub#1459
Tusespifump1o added a commit to Tusespifump1o/keras-nlp that referenced this pull request Aug 26, 2024
We can skip these by default, for users who have not yet set them up.
We will need to set them up for CI, see
keras-team/keras-hub#1459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants