Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Task and Backbone #1506

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

mattdangerw
Copy link
Member

These are already exposed on KerasCV, and I think it is time to also expose these in KerasNLP. This will give us a class to document common model functionality to all backbones such as enable_lora and token_embedding on keras.io.

It can also open up a path for writing a custom architecture outside the library itself.

These are already exposed on KerasCV, and I think it is time to
also expose these in KerasNLP. This will give us a class to document
common model functionality to all backbones such as `enable_lora`
and `token_embedding` on keras.io.

It can also open up a path for writing a custom architecture outside
the library itself.
@mattdangerw
Copy link
Member Author

mattdangerw commented Mar 11, 2024

Note that I am not exposing GenerativeTask yet, as I think we should wait for #1425 there (and expose this as two separate classes CausalLM and Seq2SeqLM).

Copy link
Member

@SamanehSaadat SamanehSaadat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt!

@mattdangerw mattdangerw merged commit 9832d8a into keras-team:master Mar 11, 2024
11 checks passed
abuelnasr0 pushed a commit to abuelnasr0/keras-nlp that referenced this pull request Apr 2, 2024
These are already exposed on KerasCV, and I think it is time to
also expose these in KerasNLP. This will give us a class to document
common model functionality to all backbones such as `enable_lora`
and `token_embedding` on keras.io.

It can also open up a path for writing a custom architecture outside
the library itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants