Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lora example to GemmaCausalLM docstring #1527

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

SamanehSaadat
Copy link
Member

No description provided.

@github-actions github-actions bot added the Gemma Gemma model specific issues label Mar 27, 2024
Copy link
Member

@mattdangerw mattdangerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, but merge away after!

keras_nlp/models/gemma/gemma_causal_lm.py Outdated Show resolved Hide resolved
@SamanehSaadat SamanehSaadat merged commit 336ce48 into keras-team:master Mar 27, 2024
6 checks passed
abuelnasr0 pushed a commit to abuelnasr0/keras-nlp that referenced this pull request Apr 2, 2024
* Add lora example to GemmaCausalLM docstring.

* Address review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gemma Gemma model specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants