Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image and audio converter classes #1813

Merged
merged 8 commits into from
Sep 10, 2024

Conversation

mattdangerw
Copy link
Member

These classes will occupy the same role as tokenizers for text models. They will transform raw inputs to model inputs in a way that is not task specific.

@mattdangerw mattdangerw force-pushed the image-audio-converter branch 5 times, most recently from 8470bd1 to 260e6aa Compare September 5, 2024 22:46
@mattdangerw
Copy link
Member Author

Still some tests failing here, but I think this is review ready enough. The image converter and audio converter "large" tests will be failing until I add some new assets on Kaggle, but I will wait for a round of review before adding them.

@mattdangerw mattdangerw force-pushed the image-audio-converter branch 3 times, most recently from 6db198e to 47f5ca1 Compare September 6, 2024 04:49
Copy link
Member

@SamanehSaadat SamanehSaadat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, Matt!
Just left some nit comments!

@mattdangerw mattdangerw added the kokoro:force-run Runs Tests on GPU label Sep 9, 2024
@mattdangerw
Copy link
Member Author

Assets added on Kaggle. This should be ready to merge now.

@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Sep 9, 2024
@mattdangerw mattdangerw added the kokoro:force-run Runs Tests on GPU label Sep 10, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Sep 10, 2024
@mattdangerw mattdangerw merged commit 23815d6 into keras-team:master Sep 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants