Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding an AlbertMaskedLM task + Fix Projection layer dimension in MaskedLMHead #725
Adding an AlbertMaskedLM task + Fix Projection layer dimension in MaskedLMHead #725
Changes from 1 commit
51fb5fb
9eb6ff4
7ee4bd6
6138b04
4dd31f7
ae25305
27be519
e7287b8
5a036ef
fb24d30
6755a20
59f65b5
d11971c
4498ab8
427b7d3
9036cec
a82350d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other follow up as you are adding the check for the mask token--we should also make sure the data you are using to train the sentencpiece model above matches the data you are passing here.
When all is working, the token id output should look something like
[bos, mask, mask mask, eos, pad, pad pad]
(replacing those symbols with the proper indices from the vocab).