Skip to content
This repository was archived by the owner on Sep 18, 2024. It is now read-only.

Get rid of Python2 #325

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Get rid of Python2 #325

merged 1 commit into from
Nov 3, 2020

Conversation

eli-osherovich
Copy link
Contributor

Summary

Related Issues

PR Overview

  • [n] This PR requires new unit tests [y/n] (make sure tests are included)
  • [n] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
  • [y] This PR is backwards compatible [y/n]
  • [n] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

Removed Python2 code because keras_preprocessing is incompatible with Python2 anymore.

@Dref360
Copy link
Contributor

Dref360 commented Nov 3, 2020

We should remove https://github.com/keras-team/keras-preprocessing/blob/master/tests/test_documentation.py#L166

as well.

@eli-osherovich
Copy link
Contributor Author

I think I removed it.

@Dref360
Copy link
Contributor

Dref360 commented Nov 3, 2020

Oh right, my bad.

Dref360
Dref360 approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@Dref360 Dref360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dref360 Dref360 merged commit 58df11e into keras-team:master Nov 3, 2020
@eli-osherovich eli-osherovich deleted the remove_old_python branch November 3, 2020 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Dref360 Dref360 Dref360 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eli-osherovich @Dref360