Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: model save when file already exists #11289

Merged
merged 4 commits into from
Oct 3, 2018
Merged

Bug fix: model save when file already exists #11289

merged 4 commits into from
Oct 3, 2018

Conversation

farizrahman4u
Copy link
Contributor

Summary

Related Issues

PR Overview

  • [y ] This PR requires new unit tests [y/n] (make sure tests are included)
  • [n ] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
  • [y ] This PR is backwards compatible [y/n]
  • [n ] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

@farizrahman4u farizrahman4u requested a review from Dref360 October 3, 2018 17:55
fchollet
fchollet approved these changes Oct 3, 2018
View reviewed changes
Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@fchollet fchollet merged commit 5a24ebb into keras-team:master Oct 3, 2018
@farizrahman4u farizrahman4u mentioned this pull request Oct 3, 2018
Merged
@farizrahman4u farizrahman4u deleted the fr_save_fix branch October 3, 2018 18:51
@farizrahman4u farizrahman4u removed the request for review from Dref360 October 3, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farizrahman4u @fchollet