[tf-2] added PIL and pandas to setup.py #12454
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I am trying to fix the tests in the tf-2 branch to make it robust with TF-2.0
Currently pytest throws 7 errors, 5 of which are import errors for libraries PIL, pandas, flaky and pyux, one is this runtime error for getting Keras backend session and the last one is this bug with pytest module.
I want to solve these one by one.
This PR solves the import errors.
2nd can be solved by removing the exception catching in that function (I checked), but would want an opinion (Because the check _is_tf_1() has been used multiple times in that script, dont know why, considering it is a tf-2 branch).
I also have a working solution for 3rd problem (remove the pytest decorators for this function)
Please let me know if I can submit those PRs as well or if I need to change my direction.
Related Issues
PR Overview