-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added rgb_to_grayscale
#19393
Added rgb_to_grayscale
#19393
Conversation
Hi @fchollet Thanks for the initial review, can you tell me how can i fix failing tests? |
There seems to be more than one issue with the unit tests. For the particular issue you mentioned, I think you just need to make sure to call |
@fchollet can you review? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19393 +/- ##
==========================================
+ Coverage 75.95% 76.24% +0.28%
==========================================
Files 366 367 +1
Lines 40707 41161 +454
Branches 7934 8051 +117
==========================================
+ Hits 30920 31384 +464
+ Misses 8074 8057 -17
- Partials 1713 1720 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update -- the code looks good overall, however the tests are still failing for two backends with shape correctness issues. Please take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@fchollet