Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loading layers with lambda in from .h5 files #19151 #19438

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

alanwilter
Copy link
Contributor

@alanwilter alanwilter commented Apr 4, 2024

This fixes the issue #19151 but I'm not sure where/how to add a test unit for this.

Copy link

google-cla bot commented Apr 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I'm not sure where/how to add a test unit for this.

It should be in keras/saving/saving_lib_test.py

keras/saving/saving_api.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.08%. Comparing base (e62b2d6) to head (c00d57b).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19438      +/-   ##
==========================================
- Coverage   76.09%   76.08%   -0.02%     
==========================================
  Files         367      367              
  Lines       41055    41055              
  Branches     8014     8014              
==========================================
- Hits        31241    31235       -6     
- Misses       8099     8103       +4     
- Partials     1715     1717       +2     
Flag Coverage Δ
keras 75.93% <100.00%> (-0.02%) ⬇️
keras-jax 60.19% <100.00%> (ø)
keras-numpy 54.12% <100.00%> (ø)
keras-tensorflow 61.41% <100.00%> (-0.02%) ⬇️
keras-torch 60.30% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alanwilter
Copy link
Contributor Author

The failing tests don't seem to have any relation with the PR here:

=========================== short test summary info ============================
FAILED keras/ops/numpy_test.py::NumpyTwoInputOpsCorretnessTest::test_quantile
FAILED keras/ops/numpy_test.py::NumpyOneInputOpsCorrectnessTest::test_median
====== 2 failed, 9542 passed, 289 skipped, 1 xfailed in 556.03s (0:09:16) ======

keras/saving/saving_api.py Show resolved Hide resolved
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 11, 2024
@fchollet fchollet merged commit 21dd61e into keras-team:master Apr 11, 2024
9 checks passed
@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

6 participants