Modified example in depthwise_conv1d file #20268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example code has changed by modifying existing code
fchollet
reviewed
Sep 18, 2024
| @@ -92,7 +92,7 @@ class DepthwiseConv1D(BaseDepthwiseConv): | |||
| Example: | |||
|
|
|||
| >>> x = np.random.rand(4, 10, 12) | |||
| >>> y = keras.layers.DepthwiseConv1D(3, 3, 2, activation='relu')(x) | |||
| >>> y = keras.layers.DepthwiseConv1D(kernel_size=3, depth_multiplier=3, strides=2, activation='relu')(x) | |||
There was a problem hiding this comment.
This wouldn't work, it's lacking the filters argument
There was a problem hiding this comment.
Hi @fchollet ,
DepthwiseConv1D doesn't have filter arguments. If the filter argument is added then it's showing this error ValueError: Unrecognized keyword arguments passed to DepthwiseConv1D: {'filters': 16}
ruidazeng
reviewed
Nov 6, 2024
| @@ -92,7 +92,7 @@ class DepthwiseConv1D(BaseDepthwiseConv): | |||
| Example: | |||
|
|
|||
| >>> x = np.random.rand(4, 10, 12) | |||
| >>> y = keras.layers.DepthwiseConv1D(3, 3, 2, activation='relu')(x) | |||
| >>> y = keras.layers.DepthwiseConv1D(kernel_size=3, depth_multiplier=3, strides=2, activation='relu')(x) | |||
There was a problem hiding this comment.
This doesn't pass the linter, every line should be below 80 characters. See below:
./keras/src/layers/convolutional/depthwise_conv1d.py:95:81: E501 line too long (108 > 80 characters)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example code has changed by modifying existing code