Switch jnp.reshape from newshape to shape paramter. #20469
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newshape parameter was deprecated in JAX v0.4.28, and will soon be removed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20469 +/- ##
==========================================
- Coverage 82.03% 77.48% -4.56%
==========================================
Files 515 515
Lines 47346 47346
Branches 7427 7427
==========================================
- Hits 38842 36684 -2158
- Misses 6705 8924 +2219
+ Partials 1799 1738 -61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fchollet
approved these changes
Nov 7, 2024
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
ready to pull
wang-xianghao
pushed a commit
to wang-xianghao/keras-dev
that referenced
this pull request
Nov 20, 2024
The newshape parameter was deprecated in JAX v0.4.28, and will soon be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newshape parameter was deprecated in JAX v0.4.28, and will soon be removed.