fix csv logger bug #21332
Merged
fix csv logger bug #21332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21332 +/- ##
==========================================
- Coverage 82.65% 82.65% -0.01%
==========================================
Files 565 565
Lines 54815 54821 +6
Branches 8511 8513 +2
==========================================
+ Hits 45310 45313 +3
- Misses 7413 7414 +1
- Partials 2092 2094 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hertschuh
reviewed
May 28, 2025
keras/src/callbacks/csv_logger.py
Outdated
| self.keys.extend(["val_" + k for k in self.keys]) | ||
|
|
||
| # Check if the model is expected to produce validation metrics. | ||
| if hasattr(self.model, "metrics_names"): |
There was a problem hiding this comment.
nitpick: you don't need if hasattr(self.model, "metrics_names"):, it's a property on the Model class:
https://github.com/keras-team/keras/blob/master/keras/src/trainers/trainer.py#L271
fchollet
approved these changes
May 29, 2025
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
awaiting review
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the issue about
CSVLogger is setting val_* metrics to nan despite no validation data being provided: #21173Colab to verify : https://colab.sandbox.google.com/drive/1tZmeU2x_DpB6q5hBtsg2pGTR4KhqK2_7#scrollTo=RtemKVh36rI6
The values to be matched between progbar and cvs logger is fixed in #21331