Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to disabe Crossref consolidation via consolidateHeader #300

Closed
de-code opened this issue Mar 29, 2018 · 4 comments
Closed

Unable to disabe Crossref consolidation via consolidateHeader #300

de-code opened this issue Mar 29, 2018 · 4 comments
Assignees
Labels
bug From Hemiptera and especially its suborder Heteroptera

Comments

@de-code
Copy link
Collaborator

de-code commented Mar 29, 2018

I am trying to disable the Crossref consolidation.

The UI has a tick box to disable it, but it doesn't seem to have an affect. I don't see the flag in the network request. (Both locally as well as on the demo site)

According to the docs, there is the consolidateHeader flag. It looks like it is a form parameter.

curl -v --form input=@./thefile.pdf --form consolidateHeader=0 http://localhost:8070/api/processHeaderDocument

That doesn't seem to have the desired effect.

It could be that it's related to this if condition that seem to ignore the flag it found the DOI:

if (consolidate || (resHeader.getDOI() != null)) {

(The document has indeed a DOI and I can see the request being made for the DOI)

Test document:
https://www.biorxiv.org/content/biorxiv/early/2018/03/26/287888.full.pdf

In that PDF, author first names are abbreviated - with consolidateHeader=0 I am expecting the XML to contain the names as per PDF. Just to show that it's not hidden somewhere, disabling access to Crossref does produce the desired result.

@kermitt2 kermitt2 self-assigned this Apr 6, 2018
@kermitt2 kermitt2 added the bug From Hemiptera and especially its suborder Heteroptera label Apr 6, 2018
@lfoppiano
Copy link
Collaborator

@kermitt2 I'm discussing with @de-code and I'm also wondering that if the consolidation is set to false, it should not be attempted, even if there is a DOI. What's the reason behind it?

Thanks

@kermitt2
Copy link
Owner

I put the label bug to this issue ;)

@lfoppiano
Copy link
Collaborator

OK, it should be fixed now 😄

@de-code
Copy link
Collaborator Author

de-code commented Apr 24, 2018

Working as expected. Thank you!

@de-code de-code closed this as completed Apr 24, 2018
de-code pushed a commit to elifesciences/grobid that referenced this issue Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug From Hemiptera and especially its suborder Heteroptera
Projects
None yet
Development

No branches or pull requests

3 participants