Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kotlin language #1096

Merged
merged 8 commits into from
May 5, 2024
Merged

Add Kotlin language #1096

merged 8 commits into from
May 5, 2024

Conversation

lfoppiano
Copy link
Collaborator

@lfoppiano lfoppiano commented Apr 12, 2024

This PR enable Kotlin in the Grobid build. #992

Kotlin is a fully JVM compatible language that allow to write code in a more efficient way. It's a compiled language that integrate seamlessly in the Java JVM machine.

We have successfully used Kotlin in Grobid-quantities since version 0.7.3 for both tests and new code.

The approach so far is to gradually move to Kotlin only for new code, in particular it fits well for writing JUnit and integration tests.

In this PR, beside enabling Kotlin I added a small test to validate that it's working.

@lfoppiano lfoppiano marked this pull request as draft April 12, 2024 01:24
@lfoppiano lfoppiano changed the title Add kotlin Add Kotlin language Apr 12, 2024
@coveralls
Copy link

coveralls commented Apr 28, 2024

Coverage Status

coverage: 39.923% (+0.02%) from 39.906%
when pulling 9db8667 on feature/kotlin
into d98129f on master.

@lfoppiano lfoppiano marked this pull request as ready for review April 28, 2024 01:22
@lfoppiano lfoppiano merged commit 664824d into master May 5, 2024
9 checks passed
@lfoppiano lfoppiano deleted the feature/kotlin branch May 5, 2024 05:15
@lfoppiano lfoppiano added this to the 0.8.1 milestone Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants