-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cors configuration #527
Cors configuration #527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ok for me
Just tested it, if I didn't make an error, I don't see the CORS info in the response header: Current master server response headers:
PR server response headers (with CORS default config in
|
I tried it with ajax/jquery and it is ok ! , I ll do further tests, something weird.. |
I need to have a look at it again ... |
Basically this implementation does not return headers if the Origin doesn't match the allowed origin or it's absent... it seems the proper way to do so, but it's not as I remember this thing... |
ah my bad, I didn't put Adding for instance |
I just added some minor corrections which were stuck in my local branch with 66de8d5 |
This should resolve #226