bpf, sockmap: Fix tp->copied_seq update in, tcp_bpf_strp_read_sock #10227
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: b54a8e1 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
f6af497 to
baaa336
Compare
Author
|
Upstream branch: 6f1f4c1 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1020412=>bpf-next
branch
from
fb13f95 to
8745e32
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
baaa336 to
b6555d5
Compare
Author
|
Upstream branch: f8c67d8 |
In the tcp_read_sock_noack function, received packets may be destined for either the current sk or another sk. In my test case, the first packet of the connection is sent to the current sk, while subsequent packets are sent to another sk. When the first packet is forwarded, tp->copied_seq is updated in tcp_bpf_recvmsg_parser. However, since psock->copied_seq accumulates the length of every processed packet, using psock->copied_seq to update tp->copied_seq when processing the second packet would lead to incorrect behavior. Therefore, we only need to update tp->copied_seq in cases where packets are forwarded to another sk. Signed-off-by: GuoYong Zheng <zhenggy@chinatelecom.cn>
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1020412=>bpf-next
branch
from
8745e32 to
13996fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf, sockmap: Fix tp->copied_seq update in, tcp_bpf_strp_read_sock
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1020412