bpf: test_run: fix ctx leak in bpf_prog_test_run_xdp error path #9986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=80&v=4){kind=small}
|
Upstream branch: 3a86608 |
|
Upstream branch: 3a86608 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1011265=>bpf
branch
from
7955833 to
544ef8c
Compare
Fix a memory leak in bpf_prog_test_run_xdp() where the context buffer
allocated by bpf_ctx_init() is not freed when the function returns early
due to a data size check.
On the failing path:
ctx = bpf_ctx_init(...);
if (kattr->test.data_size_in - meta_sz < ETH_HLEN)
return -EINVAL;
The early return bypasses the cleanup label that kfree()s ctx, leading to a
leak detectable by kmemleak under fuzzing. Change the return to jump to the
existing free_ctx label.
Fixes: fe9544e ("bpf: Support specifying linear xdp packet data size for BPF_PROG_TEST_RUN")
Reported-by: BPF Runtime Fuzzer (BRF)
Signed-off-by: Shardul Bankar <shardulsb08@gmail.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
|
Upstream branch: 3a86608 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1011265=>bpf
branch
from
544ef8c to
21be88e
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf_base
branch
from
c0f80e7 to
c172d76
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1011265 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: test_run: fix ctx leak in bpf_prog_test_run_xdp error path
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1011265