kpd: add optional mirror support #16
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always clone a full repository. This is counter productive and wasteful. Allow users to specify that they are using kpd to help test patches for a git tree which we should expect a mirror on a target mirror path. Optionally, we also allow users to clarify that their target git tree is a linux clone, and in such cases we can always fallback to looking for a mirror path with the "linux.git" name. So for example, all kdevops enterprise deployments can easily profit from this as kdevops has support to mirror all target git trees it supports under /mirror/ through an NFS export for clients. And so small thing guests can be used for kpd instances, which can leverage this NFS export. This allows kpd to be run on smaller guests with less storage needs. This should allow more than one kpd instance to run on small guests too. Generated-by: ChatGPT Codex Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
theihor
requested changes
Jul 14, 2025
Contributor
theihor
left a comment
theihor
left a comment
There was a problem hiding this comment.
A great improvement overall, thanks!
Please see comments with feedback.
Contributor
Author
|
OK! Pushed new fixes. |
Contributor
Author
|
I've addressed the feedback in #20 to limit the scope back here. |
Contributor
Author
|
Going to re-open this. |
Contributor
Author
|
OK let's see if this works |
Contributor
Author
|
@theihor I can't re-open this pull request despite all my efforts. |
Contributor
|
@mcgrof thank you for addressing the feedback. Looks like inability to re-open a closed PR after a force-push is a known github quirk: isaacs/github#361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always clone a full repository. This is counter productive and wasteful. Allow users to specify that they are using kpd to help test patches for a git tree which we should expect a mirror on a target mirror path.
Optionally, we also allow users to clarify that their target git tree is a linux clone, and in such cases we can always fallback to looking for a mirror path with the "linux.git" name.
So for example, all kdevops enterprise deployments can easily profit from this as kdevops has support to mirror all target git trees it supports under /mirror/ through an NFS export for clients. And so small thing guests can be used for kpd instances, which can leverage this NFS export.
This allows kpd to be run on smaller guests with less storage needs. This should allow more than one kpd instance to run on small guests too.
Generated-by: ChatGPT Codex