Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table filter not updating nested tests #851

Closed
Tracked by #781
, #861
...
MarceloRobert opened this issue Jan 29, 2025 · 0 comments · Fixed by #874
Closed
Tracked by #781
, #861
...

Table filter not updating nested tests #851

MarceloRobert opened this issue Jan 29, 2025 · 0 comments · Fixed by #874
Assignees
@MarceloRobert
Labels
bug Something isn't working

Comments

@MarceloRobert
Copy link
Collaborator

When an individual tests table is opened as a nesting in the tests table, it doesn't have its filter updated.
Example: https://staging.dashboard.kernelci.org:9000/issue/maestro:3d743effedc9584a60cd699b2df5f38e0773b493/version/1?tf%7Cb=a&tf%7Cbt=a&tf%7Ct=f

Open the individual tests table and change the filter to inconclusive - the table doesn't update, but if you close and reopen the nested individual tests table it will update
@MarceloRobert MarceloRobert mentioned this issue Jan 28, 2025
Open
27 tasks
@MarceloRobert MarceloRobert added the bug Something isn't working label Jan 29, 2025
@MarceloRobert MarceloRobert self-assigned this Jan 30, 2025
@WilsonNet WilsonNet mentioned this issue Jan 30, 2025
Open
21 tasks
@MarceloRobert MarceloRobert moved this from Todo to In Progress in KernelCI Web Dashboard Feb 3, 2025
MarceloRobert added a commit that referenced this issue Feb 3, 2025
@MarceloRobert
fix: update expanded rows on filter
4d22dc3 
Removes memo with no dependency from IndividualTestsTable, allowing it to update when the data updates. This works for all uses of IndividualTestsTable, no matter the page/tab

Also fixes a small visual bug where there was a gap at the bottom of expanded rows

Closes #851
@MarceloRobert MarceloRobert mentioned this issue Feb 3, 2025
Merged
@MarceloRobert MarceloRobert moved this from In Progress to In Review in KernelCI Web Dashboard Feb 3, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in KernelCI Web Dashboard Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarceloRobert MarceloRobert

Labels
bug Something isn't working
Projects
KernelCI Web Dashboard
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: filter expanded rows kernelci/dashboard
1 participant
@MarceloRobert