Refactor: improve no data response #838
Merged
+175
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Francisco2002
force-pushed
the
refactor/improve-no-data-response
branch
from
a942a2e to
8451117
Compare
There was a problem hiding this comment.
Since you are changing some responses, I would add the changes of some messages to be clearer. Saying for example "Builds not found" for the builds of an issue makes it seem like an issue is supposed to have builds but they weren't found, which is not true. Saying "No builds found for this issue" doesn't imply anything, it just says that no builds were found.
Francisco2002
force-pushed
the
refactor/improve-no-data-response
branch
from
8451117 to
413ae17
Compare
- create type to response with error prop - create function to throw a error message Part of #784
Francisco2002
force-pushed
the
refactor/improve-no-data-response
branch
from
413ae17 to
8a8849d
Compare
Francisco2002
force-pushed
the
refactor/improve-no-data-response
branch
from
8a8849d to
2bd510f
Compare
MarceloRobert
approved these changes
Jan 24, 2025
Create a issue for that #841 |
- change the status code from 404 to 200 (OK) - use makeRequest function to treat error from endpoint in the frontend - show error message in SectionError component Part of #784
Francisco2002
force-pushed
the
refactor/improve-no-data-response
branch
from
2bd510f to
6bbc998
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the response for not found data
Close #784