Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid message processing #461

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Conversation

spbnick
Copy link
Collaborator

@spbnick spbnick commented Aug 23, 2023

This fixes the submission queue blockage due to invalid messages not being safely discarded, trying to make their way into the database, failing, and aborting the kcidb_load_queue Cloud Function. We've had this problem before, and it resurfaced because of refactoring of I/O validation. There's now an issue about making a test for this.

@spbnick spbnick temporarily deployed to staging August 23, 2023 17:02 — with GitHub Actions Inactive
@spbnick spbnick merged commit 1ed6bf9 into main Aug 23, 2023
@spbnick spbnick deleted the fix_invalid_message_processing branch August 23, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant