Fix sparc64 build (#1178) #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montjoie
approved these changes
Aug 1, 2022
|
Build fails: I think because for sparc, it generates image in arch/sparc/boot, there is no arch/sparc64 |
For testing sparc hardware and qemu, we need to build Linux for sparc64 arch. Signed-off-by: Corentin LABBE <clabbe@baylibre.com> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
Fix the make target and kernel image name for sparc64 as the standard name is zImage. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
Fix the cross-compile string for sparc64 based on the Debian toolchain. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
gctucker
force-pushed
the
fixup-1178-sparc64
branch
from
4b745e8 to
c156181
Compare
|
Should i retest or its not fixed yet? |
Rename the "sparc64" architecture to "sparc" which is the one used in the kernel source tree. The 32/64 choice can be made by building either the sparc32_defconfig or sparc64_defconfig using the same sparc64 toolchain. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
gctucker
force-pushed
the
fixup-1178-sparc64
branch
from
99ffb90 to
b9b4ea6
Compare
The kernel architecture name for sparc64 is sparc, so rename the sparc64 Docker image to sparc accordingly. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
Add a regex filter in the defaults for the sparc architecture with sparc64_defconfig to only build this one unless otherwise specified. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
|
I'm testing this on staging |
Update the dictionary with the kernel image names to use "sparc" instead of "sparc64" as the arch name. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
gctucker
commented
Aug 3, 2022
There was a problem hiding this comment.
Tested OK on staging: https://staging.kernelci.org/build/id/62ea3147871156cf5fe19da7/
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick the change from #1178 to enable sparc64 builds and fix a few issues to get it to work as expected. This does not include the QEMU changes for running tests.