[RFC] kci-argparse: add kci PoC using argparse #2119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a kci-argparse proof-of-concept replacement for kci using the standard argparse module. It comes with a sample kernelci-argparse.toml settings file to illustrate how the values can be combined with the command line arguments. This implementation isn't quite complete as nested commands can't really be implemented with argparse as easily as with Click or derivatives such as Typer. While it may be possible, this PoC is about comparing solutions and it's clear that using argparse would require a lot of addtional work to provide the same user experience as with Click. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
|
Closing this RFC now as we've reached a consensus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a kci-argparse proof-of-concept replacement for kci using the standard argparse module. It comes with a sample
kernelci-argparse.toml settings file to illustrate how the values can be combined with the command line arguments.
This implementation isn't quite complete as nested commands can't really be implemented with argparse as easily as with Click or derivatives such as Typer. While it may be possible, this PoC is about comparing solutions and it's clear that using argparse would require a lot of addtional work to provide the same user experience as with Click.