Rework kci docker with new framework
#2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gctucker
force-pushed
the
kci-docker-rework
branch
5 times, most recently
from
7aeee4f to
ab548a8
Compare
gctucker
force-pushed
the
kci-docker-rework
branch
8 times, most recently
from
365c8fd to
55ef9e2
Compare
This was referenced Oct 19, 2023
gctucker
force-pushed
the
kci-docker-rework
branch
from
55ef9e2 to
71f034e
Compare
|
Still not tested on staging,
|
|
Yeah obviously, all the other PRs need to be rebased now that the TOML one got merged. |
gctucker
force-pushed
the
kci-docker-rework
branch
2 times, most recently
from
a8f7410 to
02940b0
Compare
|
@nuclearcat @hardboprobot @JenySadadia This is ready to be reviewed, if one of you is available. Also maybe assign it to yourself so it doesn't get reviewed by more than one person? |
gctucker
force-pushed
the
kci-docker-rework
branch
from
02940b0 to
13728ec
Compare
Add kernelci.docker as a module to manage KernelCI Docker images. This will provide the actual implementation behind the new 'kci docker' command based on Click. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
Add kernelci.cli.docker subcommand for the new `kci docker` implementation based on kernelci.docker and Click. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
Remove the old `kci docker` implementation based on argparse as there's now the new one based on Click and the kernelci.docker module. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
gctucker
force-pushed
the
kci-docker-rework
branch
from
13728ec to
a8d1743
Compare
|
tested on staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the
kci dockercommand with the newkernelci.climodule based on Click.