Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernelci.cli: add storage subcommand #2161

Merged
merged 1 commit into from
Nov 7, 2023
Merged

kernelci.cli: add storage subcommand #2161

merged 1 commit into from
Nov 7, 2023

Conversation

gctucker
Copy link
Contributor

@gctucker gctucker commented Nov 3, 2023 •
edited
Loading

Add implementation for kci storage upload subcommand using the new framework with Click.

Fixes #2158

@gctucker gctucker mentioned this pull request Nov 4, 2023
Open
40 tasks
r-c-n
r-c-n reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@r-c-n r-c-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but changes look pretty straightforward. If the author has tested them, then it LGTM besides the comments.

kernelci/cli/storage.py Outdated Show resolved Hide resolved
kernelci/cli/storage.py Show resolved Hide resolved
@gctucker
Copy link
Contributor Author

gctucker commented Nov 7, 2023

Untested, but changes look pretty straightforward

Feel free to test it, the new Azure Files tokens have been sent to everyone so you should be able to follow the Early Access steps if you want to give it a try (the version on staging with the update page of course).

@gctucker
Copy link
Contributor Author

gctucker commented Nov 7, 2023

It's true I don't think we have unit tests for kernelci.storage yet. Well it's not a new thing with this PR, something else to improve I guess.

@r-c-n
Copy link
Contributor

r-c-n commented Nov 7, 2023

Untested, but changes look pretty straightforward

Feel free to test it, the new Azure Files tokens have been sent to everyone so you should be able to follow the Early Access steps if you want to give it a try (the version on staging with the update page of course).

I'm taking the time to review and understand the code but I can't test every PR I review because testing them is not trivial and it'll take a considerable amount of time, and I can't afford that right now. If you tested it and it works, that's enough proof for me given the current situation.

@gctucker
Copy link
Contributor Author

gctucker commented Nov 7, 2023

OK I'm not asking you to test it. Please approve it when / if you're happy with it.

@r-c-n
Copy link
Contributor

r-c-n commented Nov 7, 2023

OK I'm not asking you to test it. Please approve it when / if you're happy with it.

There's still this #2161 (comment) if you're ok with it.

@gctucker
kernelci.cli: add storage subcommand
31a45b8 
Add implementation for `kci storage upload` subcommand using the new
framework with Click.

Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
@gctucker gctucker added this pull request to the merge queue Nov 7, 2023
Merged via the queue into kernelci:main with commit c84053a Nov 7, 2023
4 checks passed
@gctucker gctucker deleted the cli-storage branch November 7, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-c-n r-c-n r-c-n left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors on kci commands references in Early Access guide
2 participants
@gctucker @r-c-n