-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kernelci.cli: allow multiple values for .split_attributes() #2195
Conversation
10ed502
to
5586869
Compare
But is it implemented in API side? I think this way we are entering a bit uncharted territory of boolean logic, right now by default we have AND as i understand, but in this case it becomes OR? |
No it's not implemented on the API side yet. |
83997da
to
22682da
Compare
Allow the same attribute to be provided several times in .split_attributes(). This is useful when looking for database entries that match one of a set of values e.g. name=foo?name=bar to find entries named 'foo' or 'bar'. Update unit tests accordingly with an additional one to test the generated request URL with multiple values for the same parameter. Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
22682da
to
c36cfaf
Compare
Tested locally:
This doesn't return the user with the name |
I thought we were trying to fix the issue I mentioned in #2184 (comment). When multiple values for |
Yes, I'm not sure if the API can handle things properly. But at least the logic here on the client side is working to produce the right URL. |
This works when I send multiple
When I send just one
I guess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handling groups
can be a follow-up PR. Merging this now.
Ah, yes the whole group handling thing will need to be revisited. That can be done as part of the work to add the |
Allow the same attribute to be provided several times in .split_attributes(). This is useful when looking for database entries that match one of a set of values e.g. name=foo?name=bar to find entries named 'foo' or 'bar'.
Update unit tests accordingly with an additional one to test the generated request URL with multiple values for the same parameter.