Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework kci pubsub commands with Click framework #2203

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Rework kci pubsub commands with Click framework #2203

merged 2 commits into from
Nov 28, 2023

Conversation

JenySadadia
Copy link
Collaborator

Rework CLI tools to interact with the API PubSub interface with Click framework.
Added kci event commands.

gctucker
gctucker reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@gctucker gctucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK this doesn't change any of the bindings so it can be done in parallel of the API class rework. Then when adding the queue commands etc. with new bindings, it would be good to do it directly on top of the reworked API class with a nested class for events.

kci Outdated Show resolved Hide resolved
kernelci/cli/event.py Outdated Show resolved Hide resolved
kernelci/cli/event.py Outdated Show resolved Hide resolved
kernelci/cli/event.py Outdated Show resolved Hide resolved
kernelci/cli/event.py Show resolved Hide resolved
Jeny Sadadia added 2 commits November 22, 2023 10:31
kernelci.cli.event: rework kci pubsub commands
f32d8a7 
Rework CLI tools to interact with the API PubSub
interface with `Click` framework.
Rename group of commands from `kci pubsub` to `kci event`
and add sub-commands to subscribe, unsubscribe,
receive and send events.

Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
kernelci.legacy.cli: remove kci pubsub
24b5ad2 
Remove CLI tool for API PubSub from `kernelci.legacy`
module as it has been reworked and added to
`kernelci.cli` module.

Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
@JenySadadia JenySadadia mentioned this pull request Nov 22, 2023
Merged
nuclearcat
nuclearcat approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@nuclearcat nuclearcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on staging:
subscribe, receive, unsubscribe, send

@nuclearcat nuclearcat added this pull request to the merge queue Nov 28, 2023
Merged via the queue into kernelci:main with commit 089b0c2 Nov 28, 2023
4 checks passed
@JenySadadia JenySadadia deleted the rework-kci-pubsub branch November 28, 2023 10:16
@gctucker gctucker mentioned this pull request Dec 15, 2023
Open
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gctucker gctucker gctucker left review comments

@nuclearcat nuclearcat nuclearcat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JenySadadia @nuclearcat @gctucker