Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernelci.cli: rework kci job commands with Click #2220

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

JenySadadia
Copy link
Collaborator

Rework kci commands to manage KernelCI jobs with Click framework.

Tested locally for kver job:

$ ./kci job new kver --node-id=6465cd3c73281d29430d3071
{"id": "656ad50f8cff329b0e4ad092", "kind": "node", "name": "kver", "path": ["checkout", "kver"], "group": "kver", "revision": {"tree": "kernelci", "url": "https://github.com/kernelci/linux.git", "branch": "staging-mainline", "commit": "ac37cbde135450309a2b6c3b66331912d744b4c9", "describe": "staging-mainline-20230517.0", "version": {"version": 6, "patchlevel": 4, "sublevel": null, "extra": "-rc2-1-gac37cbde1354", "name": null}}, "parent": "6465cd3c73281d29430d3071", "state": "running", "result": null, "artifacts": {"tarball": "http://172.17.0.1:8002/linux-kernelci-staging-mainline-staging-mainline-20230517.0.tar.gz"}, "data": null, "created": "2023-12-02T06:56:15.243717", "updated": "2023-12-02T06:56:15.243726", "timeout": "2023-12-02T12:56:15.243734", "holdoff": null, "owner": "admin", "user_groups": []}


$ ./kci job generate 656ad50f8cff329b0e4ad092 --platform=shell --yaml-config=config/pipeline.yaml  --output=.
Job saved in ./kver


$ ./kci job submit ./kver --wait
17202
Getting kernel source tree...
Source directory: /tmp/kci/linux-kernelci-staging-mainline-staging-mainline-20230517.0
Running job...
Checking kernel revision
Result: pass
Job completed with status: 0

Rework `kci` commands to manage KernelCI jobs
with `Click` framework.

Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
Copy link
Contributor

@gctucker gctucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK following the merge-and-fix approach to untangle the various pending PRs and conflicts with kernelci-api related changes.

@gctucker
Copy link
Contributor

gctucker commented Dec 5, 2023

It's a shame we didn't sync up properly, I wrote this already a month ago (3rd Nov) and didn't submit a PR because of the other pending changes. Now there'a bunch of conflicts to resolve and things to fix with the new API abstract class and CLI tools but I'll send some new PRs this week to put things back on track.

@gctucker gctucker added this pull request to the merge queue Dec 5, 2023
Merged via the queue into kernelci:main with commit 9ef18ea Dec 5, 2023
4 checks passed
@JenySadadia JenySadadia deleted the kci-job-rework branch December 5, 2023 09:57
@gctucker gctucker mentioned this pull request Dec 15, 2023
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants