Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernelci.cli: use click.File for reading input #2233

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

gctucker
Copy link
Contributor

@gctucker gctucker commented Dec 8, 2023

Use click.File rather than sys.stdin for reading input data.  If the
file name is '-' then it will use stdin which is standard practice.

Use click.File rather than sys.stdin for reading input data.  If the
file name is '-' then it will use stdin which is standard practice.

Signed-off-by: Guillaume Tucker <gtucker@gtucker.io>
@gctucker gctucker marked this pull request as ready for review December 14, 2023 09:05
Copy link
Collaborator

@JenySadadia JenySadadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK.

@JenySadadia JenySadadia added this pull request to the merge queue Dec 14, 2023
Merged via the queue into kernelci:main with commit 058ea4a Dec 14, 2023
4 checks passed
@gctucker gctucker deleted the cli-click-input-file branch December 14, 2023 12:24
@gctucker gctucker mentioned this pull request Dec 15, 2023
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants