kernelci.cli.user: send token to GET users requests #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send API token for getting existing users' information as the endpoint has made accessible to only authorized users. Signed-off-by: Jeny Sadadia <jeny.sadadia@collabora.com>
nuclearcat
approved these changes
Dec 8, 2023
|
@JenySadadia Why has authentication been added there? Is this a |
|
We had discussion and decided it is not good idea to expose usernames and emails without authentication from privacy standpoint. |
|
OK, this seems a bit arbitrary. I would have added a field to let users mask their email address if they didn't want to share it publicly. I guess that can always be done later. Only real issue as far as I'm concerned is I need to rebase my PRs again so I can finally get my old changes merged ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends kernelci/kernelci-api#430
Send API token for getting existing users' information as the endpoint has made accessible to only authorized users.