-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum python version to 3.10 #2381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Turns out I did not verify it thoroughly enough: those
It's far from perfect solution but could we keep 3.10 requirement in the GitHub workflows and relax |
Well most of those deployment details completely fly over my head, to be honest. So I trust your decision. The only reason I did this PR is to unblock this one, whose Gitlab CI tests are failing until this one is merged, supposedly. So as long as I can get that to work, anything you decide is fine by me. |
@pawiecz Thank you for your findings. |
I will add skip-staging label as at moment it is breaking staging |
@JenySadadia For a long term solution I believe a way to go would be updating
But we can do that after M1 - for now let's go with relaxed package requirements and strict GH workflow. |
Certain code features require python >= 3.10. This year is also when python 3.8 reaches EOL. Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
Certain code features require python >= 3.10. This year is also when python 3.8 reaches EOL. Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
91ba870
to
2ff9a9a
Compare
LGTM, I'm taking |
I'll merge it. Thanks. |
No description provided.