feat(storage.yaml): Add new storage #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearcat
force-pushed
the
add-kci-storage
branch
4 times, most recently
from
a8738dd to
6642ac0
Compare
pawiecz
approved these changes
Jan 13, 2025
|
|
||
| kci-storage: | ||
| storage_type: backend | ||
| base_url: http://mon.kernelci.org:3000/ |
There was a problem hiding this comment.
I recall you mentioning that storage on this system fills up pretty quickly and also that these config changes are just temporary - let's verify all the bits in this PR and move to the permanent config values as a next step.
| @@ -40,8 +40,10 @@ def generate(self, job, params): | |||
| instance = os.getenv('KCI_INSTANCE', 'prod') | |||
| if instance == 'prod': | |||
| params['k8s_api_key'] = 'kci-api-jwt-early-access' | |||
| params['k8s_storage_token_name'] = 'production' | |||
There was a problem hiding this comment.
This might cause some headache later when working with localinstall or other non-managed Maestro instances but should be fine in the current setup.
Usage of os.getenv('KCI_INSTANCE', ...) needs to be tracked and reduced over time, though.
nuclearcat
changed the title
Add new kernelci-storage definition. It is plain http storage, already supported as "backend". Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
nuclearcat
force-pushed
the
add-kci-storage
branch
from
6642ac0 to
5d72ea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new kernelci-storage definition.
It is plain http storage, already supported as "backend".