-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable discoverable devices probe kselftest on MediaTek chromebooks #642
Enable discoverable devices probe kselftest on MediaTek chromebooks #642
Conversation
Manual LAVA runs for reference: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (left a few minor comments)
6ea38af
to
e1d7e56
Compare
Since the dependencies are available in staging I've removed staging-skip label. |
e1d7e56
to
a4c6b71
Compare
I just noticed that I forgot to document that this change also depends on a kernel series: https://lore.kernel.org/all/20240613-kselftest-discoverable-probe-mt8195-kci-v1-0-7b396a9b032d@collabora.com It is present on linux-next, so I've updated the |
a4c6b71
to
3f4fac6
Compare
I've updated the kselftest collection name to |
3f4fac6
to
ab0ff3d
Compare
I've generated the rootfs on staging for kernelci/kernelci-core#2577 and updated the URL here, so removing the staging-skip tag so this can get tested. |
Tested on all platforms. MT8186 OK: MT8183 OK: MT8192 not OK: MT8195 partial OK: So once kernelci/kernelci-core#2577 is merged and the rootfs available in the production storage, its URL can be updated here and this PR merged. |
Can you please rebase and let's merge? |
@nuclearcat I also need to update the rootfs URL to the production rootfs URL for bookworm-kselftest, but the latest in https://storage.kernelci.org/images/rootfs/debian/bookworm-kselftest/ is still |
@nfraprado we have CI for this here (https://github.com/kernelci/kernelci-core/actions/workflows/rootfs.yml). Not sure if you require permissions to run it. Click on "Run Workflow". Select the branch, rootfs name, architecture and destination. The destination must be staging for verification of rootfs. Once you verify the results of your test on staging, create the rootfs on production and then merge the PR. |
Hm, I just ran it here: https://github.com/kernelci/kernelci-core/actions/runs/11165276908/job/31036570425 But still don't see it in https://storage.staging.kernelci.org/images/rootfs/debian/bookworm-kselftest/ |
I've created a job (https://github.com/kernelci/kernelci-core/actions/runs/11176504665) as well with the parameters mentioned in the above image. I'm unable to find the artifacts on storage.staging. I'll leave it and let it get debugged by original authors. |
https://storage.staging.kernelci.org/rootfs/bookworm-kselftest/ |
Update the URL for the kselftest rootfs to the latest which includes python-yaml and the files from the platform-test-parameters repository which are required to run the 'devices/probe' kselftest. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Enable the discoverable devices probe kselftest. It relies on platform-specific files to parametrize the test which are stored in https://github.com/kernelci/platform-test-parameters and deployed to the kselftest rootfs. The path to the platform specific files is passed through the kselftest env variable. Depends on Linaro/test-definitions#511, kernelci/kernelci-core#2577 and https://lore.kernel.org/all/20240613-kselftest-discoverable-probe-mt8195-kci-v1-0-7b396a9b032d@collabora.com. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Enable the discoverable devices probe kselftest on the mediatek chromebooks. In order for the tests to pass on mt8195-cherry-tomato-r2, kernelci/platform-test-parameters#1 is needed. Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
ab0ff3d
to
04fe674
Compare
Tested OK: https://lava.collabora.dev/scheduler/job/15963263 So I've deployed the rootfs to production: https://github.com/kernelci/kernelci-core/actions/runs/11220957370 And updated the PR here to use the proper URL for the production rootfs. So now it's ready to merge. |
Enable the discoverable devices probe kselftest on the MediaTek Chromebook platforms. This test will validate that the devices connected through USB or PCI on those platforms have been probed successfully. The devices are, namely, the camera on mt8183-juniper and mt8186-steelix, and the camera, wifi and bluetooth on mt8195-tomato.
Depends on kernelci/kernelci-core#2577.
Fixes #579 .