Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable discoverable devices probe kselftest on MediaTek chromebooks #642

Merged

Conversation

nfraprado
Copy link
Contributor

@nfraprado nfraprado commented Jun 13, 2024

Enable the discoverable devices probe kselftest on the MediaTek Chromebook platforms. This test will validate that the devices connected through USB or PCI on those platforms have been probed successfully. The devices are, namely, the camera on mt8183-juniper and mt8186-steelix, and the camera, wifi and bluetooth on mt8195-tomato.

Depends on kernelci/kernelci-core#2577.

Fixes #579 .

@nfraprado nfraprado added the staging-skip Don't test automatically on staging.kernelci.org label Jun 13, 2024
@nfraprado
Copy link
Contributor Author

Copy link
Contributor

@pawiecz pawiecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (left a few minor comments)

config/pipeline.yaml Outdated Show resolved Hide resolved
config/pipeline.yaml Outdated Show resolved Hide resolved
config/pipeline.yaml Outdated Show resolved Hide resolved
config/scheduler-chromeos.yaml Outdated Show resolved Hide resolved
@nfraprado nfraprado force-pushed the kselftest-discoverable-device-probe branch from 6ea38af to e1d7e56 Compare July 5, 2024 17:46
@nfraprado nfraprado removed the staging-skip Don't test automatically on staging.kernelci.org label Jul 5, 2024
@nfraprado
Copy link
Contributor Author

Since the dependencies are available in staging I've removed staging-skip label.

@nfraprado nfraprado force-pushed the kselftest-discoverable-device-probe branch from e1d7e56 to a4c6b71 Compare July 5, 2024 18:15
@nfraprado
Copy link
Contributor Author

I just noticed that I forgot to document that this change also depends on a kernel series: https://lore.kernel.org/all/20240613-kselftest-discoverable-probe-mt8195-kci-v1-0-7b396a9b032d@collabora.com

It is present on linux-next, so I've updated the rules for the job accordingly so the PR can already be tested and will run only on next. Also added a comment about how to change the rule in ~3 weeks from now to start running this test on mainline as well.

config/pipeline.yaml Outdated Show resolved Hide resolved
@nfraprado nfraprado force-pushed the kselftest-discoverable-device-probe branch from a4c6b71 to 3f4fac6 Compare July 18, 2024 20:39
@nfraprado
Copy link
Contributor Author

I've updated the kselftest collection name to devices/probe following the move in https://lore.kernel.org/all/20240705-dev-err-log-selftest-v2-1-163b9cd7b3c1@collabora.com

@a-wai a-wai added the staging-skip Don't test automatically on staging.kernelci.org label Aug 6, 2024
@nfraprado nfraprado force-pushed the kselftest-discoverable-device-probe branch from 3f4fac6 to ab0ff3d Compare September 12, 2024 20:55
@nfraprado
Copy link
Contributor Author

I've generated the rootfs on staging for kernelci/kernelci-core#2577 and updated the URL here, so removing the staging-skip tag so this can get tested.

@nfraprado nfraprado removed the staging-skip Don't test automatically on staging.kernelci.org label Sep 12, 2024
@nfraprado
Copy link
Contributor Author

Tested on all platforms.

MT8186 OK:
https://lava.collabora.dev/scheduler/job/15670426

MT8183 OK:
https://lava.collabora.dev/scheduler/job/15672968

MT8192 not OK:
https://lava.collabora.dev/scheduler/job/15672970
The board file was not present in repo. Now merged through kernelci/platform-test-parameters#2.

MT8195 partial OK:
https://lava.collabora.dev/scheduler/job/15672971
USB devices were failing due to unmerged PR, has been merged now.

So once kernelci/kernelci-core#2577 is merged and the rootfs available in the production storage, its URL can be updated here and this PR merged.

@nuclearcat
Copy link
Member

Can you please rebase and let's merge?

@nfraprado
Copy link
Contributor Author

@nuclearcat I also need to update the rootfs URL to the production rootfs URL for bookworm-kselftest, but the latest in https://storage.kernelci.org/images/rootfs/debian/bookworm-kselftest/ is still 20240313.0/, so it seems that the rootfs hasn't been generated yet with kernelci/kernelci-core#2577 merged. Does the production rootfs generation need to be done manually?

@musamaanjum
Copy link
Contributor

@nfraprado we have CI for this here (https://github.com/kernelci/kernelci-core/actions/workflows/rootfs.yml). Not sure if you require permissions to run it.

Click on "Run Workflow". Select the branch, rootfs name, architecture and destination. The destination must be staging for verification of rootfs. Once you verify the results of your test on staging, create the rootfs on production and then merge the PR.

@nfraprado
Copy link
Contributor Author

@musamaanjum
Copy link
Contributor

musamaanjum commented Oct 4, 2024

Screenshot from 2024-10-04 13-19-15

I've created a job (https://github.com/kernelci/kernelci-core/actions/runs/11176504665) as well with the parameters mentioned in the above image. I'm unable to find the artifacts on storage.staging.

I'll leave it and let it get debugged by original authors.

@nuclearcat
Copy link
Member

nuclearcat commented Oct 6, 2024

https://storage.staging.kernelci.org/rootfs/bookworm-kselftest/
I will try to figure out how to print somewhere full location of newly generated rootfs.

Update the URL for the kselftest rootfs to the latest which includes
python-yaml and the files from the platform-test-parameters repository
which are required to run the 'devices/probe' kselftest.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Enable the discoverable devices probe kselftest. It relies on
platform-specific files to parametrize the test which are stored in
https://github.com/kernelci/platform-test-parameters and deployed to the
kselftest rootfs.

The path to the platform specific files is passed through the kselftest
env variable.

Depends on Linaro/test-definitions#511,
kernelci/kernelci-core#2577
and
https://lore.kernel.org/all/20240613-kselftest-discoverable-probe-mt8195-kci-v1-0-7b396a9b032d@collabora.com.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Enable the discoverable devices probe kselftest on the mediatek
chromebooks. In order for the tests to pass on mt8195-cherry-tomato-r2,
kernelci/platform-test-parameters#1 is needed.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
@nfraprado nfraprado force-pushed the kselftest-discoverable-device-probe branch from ab0ff3d to 04fe674 Compare October 7, 2024 18:05
@nfraprado
Copy link
Contributor Author

Tested OK: https://lava.collabora.dev/scheduler/job/15963263

So I've deployed the rootfs to production: https://github.com/kernelci/kernelci-core/actions/runs/11220957370

And updated the PR here to use the proper URL for the production rootfs. So now it's ready to merge.

@nuclearcat nuclearcat added this pull request to the merge queue Oct 7, 2024
Merged via the queue into kernelci:main with commit df2622d Oct 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable 'discoverable devices probe' kselftest on MediaTek Chromebooks
6 participants