Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rngd by default #802

Closed
wants to merge 1 commit into from
Closed

Enable rngd by default #802

wants to merge 1 commit into from

Conversation

troglobit
Copy link
Contributor

Description

Platforms with /dev/hwrandom should use that to see /dev/urandom. We already have rngd from rng-tools installed, so all we need to do is start it early at boot.

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

Platforms with /dev/hwrandom use that to see /dev/urandom.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit requested a review from wkz November 5, 2024 12:34
Copy link
Contributor

@wkz wkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kernel docs seem to indicate that we're already sourcing entropy from HWRNGs when available (last paragraph):

menuconfig HW_RANDOM
        tristate "Hardware Random Number Generator Core support"
        default m
        help
          Hardware Random Number Generator Core infrastructure.

          To compile this driver as a module, choose M here: the
          module will be called rng-core.  This provides a device
          that's usually called /dev/hwrng, and which exposes one
          of possibly several hardware random number generators.

          These hardware random number generators do feed into the
          kernel's random number generator entropy pool.

Result of AFK discussion: We probably don't need this.

@troglobit
Copy link
Contributor Author

Thanks for the review, gave us a chance to discuss this in a bigger group!

@troglobit troglobit closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants