Fix double counting weakness multiplier #767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OCMEntityDamageByEntityEvent should be calculating the base damage by removing potion effect modifiers like weakness from the raw damage amount. Instead of adding back the damage lost from the vanilla potion effect, The OCMEntityDamageByEntityEvent subtracts the weakness modifier and subtracts the weakness again in EntityDamageByEntityListener. Reproduction Steps. Attack an entity with a diamond sword without weskness. Base damage is 8.0 and final damage is 0.0 instead of the expected 4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCMEntityDamageByEntityEvent should be calculating the base damage by removing potion effect modifiers like weakness from the raw damage amount.
Instead of adding back the damage lost from the vanilla potion effect, The OCMEntityDamageByEntityEvent subtracts the weakness modifier and subtracts the weakness again in EntityDamageByEntityListener.
Reproduction Steps.
Attack an entity with a diamond sword without weakness. Base damage is 8.0 and final damage is 0.0 instead of the expected 4.0.
config.yml.txt