Fixes issue swagger-api#1129

kerrykimbrough · Jun 18, 2019 · 413b10c · 413b10c
1 parent 0b2a65e
commit 413b10c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/util/OpenAPIDeserializer.java b/modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/util/OpenAPIDeserializer.java
@@ -2242,6 +2242,8 @@ public Schema getSchema(ObjectNode node, String location, ParseResult result){
             for (JsonNode n : enumArray) {
                 if (n.isNumber()) {
                     schema.addEnumItemObject(n.numberValue());
+                } else if (n.isBoolean()) {
+                    schema.addEnumItemObject(n.booleanValue());
                 } else if (n.isValueNode()) {
                     try {
                         schema.addEnumItemObject( getDecodedObject( schema, n.asText(null)));

diff --git a/...es/swagger-parser-v3/src/test/java/io/swagger/v3/parser/util/OpenAPIDeserializerTest.java b/...es/swagger-parser-v3/src/test/java/io/swagger/v3/parser/util/OpenAPIDeserializerTest.java
@@ -878,6 +878,8 @@ public void testDeserializeEnum() {
                 "                    $ref: '#/components/schemas/IntegerEnum'\n" +
                 "                  ne:\n" +
                 "                    $ref: '#/components/schemas/NumberEnum'\n" +
+                "                  be:\n" +
+                "                    $ref: '#/components/schemas/BooleanEnum'\n" +
                 "components:\n" +
                 "  schemas:\n" +
                 "    StringEnum:\n" +
@@ -886,6 +888,10 @@ public void testDeserializeEnum() {
                 "      enum:\n" +
                 "        - First\n" +
                 "        - Second\n" +
+                "    BooleanEnum:\n" +
+                "      enum:\n" +
+                "        - true \n" +
+                "        - false \n" +
                 "    IntegerEnum:\n" +
                 "      type: integer\n" +
                 "      default: 1\n" +
@@ -934,6 +940,13 @@ public void testDeserializeEnum() {
         assertEquals(new BigDecimal("1.6161"), numberValues.get(2));
         assertEquals(new BigDecimal("3.14"), numberValues.get(3));
         assertEquals(numberImpl.getDefault(), new BigDecimal("3.14"));
+
+        Schema booleanModel = resolved.getComponents().getSchemas().get("BooleanEnum");
+        assertEquals("boolean", booleanModel.getType());
+        List<Object> booleanValues = booleanModel.getEnum();
+        assertEquals(2, booleanValues.size());
+        assertEquals(Boolean.TRUE, booleanValues.get(0));
+        assertEquals(Boolean.FALSE, booleanValues.get(1));
     }
 
     @Test