-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow separate friendly nameplate sizing, fixes issues 639 and 593 #679
base: master
Are you sure you want to change the base?
allow separate friendly nameplate sizing, fixes issues 639 and 593 #679
Conversation
hello could u help me? why its not work for "weight" |
Hi - oops, my bad. I only really cared what happened inside raid instances where you can't edit the friendly nameplates anyways, so I didn't notice it wasn't actually changing the width/height. I pushed some changes that should fix the issue, so pull and retry? |
for index, data in ipairs(f) do | ||
print(index) | ||
|
||
for key, value in pairs(data) do | ||
print('\t', key, value) | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can remove these after you're done working on the PR please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for index, data in ipairs(f) do | |
print(index) | |
for key, value in pairs(data) do | |
print('\t', key, value) | |
end | |
end |
Would be cool if we could merge this - is anything else needed?
Hi - I don't play WoW anymore, finally quit after 20 years :) hooray.
Feel free to merge or whatever, but I haven't tested it in the new expac.
…On Fri, Nov 15, 2024 at 9:44 AM Dominik Wagner ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Kui_Nameplates_Core/create.lua
<#679 (comment)>
:
> + for index, data in ipairs(f) do
+ print(index)
+
+ for key, value in pairs(data) do
+ print('\t', key, value)
+ end
+ end
⬇️ Suggested change
- for index, data in ipairs(f) do
- print(index)
-
- for key, value in pairs(data) do
- print('\t', key, value)
- end
- end
Would be cool if we could merge this - is anything else needed?
—
Reply to this email directly, view it on GitHub
<#679 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOFMV7VPNELEEQVJFDGVKL2AYCDTAVCNFSM6AAAAABR3KWYJ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMZYHAYDANZWHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Hi -
Love the addon so I've added a feature to resize friendly nameplates separately from hostile.
I tried to make the changes as simple as possible. My goal is just to call the blizzard SetNamePlateFriendlySize function with small values so that friendly name only nameplates can overlap in world. This makes it so the names on their heads are much more useful as they stick to peoples heads instead of bouncing everywhere.
I shrunk some empty space on the frame size config page to keep it on one page, at least for my resolution.
PS I attempted to add translations for german, spanish, and french but I don't know the other languages well enough.
<3