Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow separate friendly nameplate sizing, fixes issues 639 and 593 #679

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

krazdord
Copy link

Hi -
Love the addon so I've added a feature to resize friendly nameplates separately from hostile.
I tried to make the changes as simple as possible. My goal is just to call the blizzard SetNamePlateFriendlySize function with small values so that friendly name only nameplates can overlap in world. This makes it so the names on their heads are much more useful as they stick to peoples heads instead of bouncing everywhere.
I shrunk some empty space on the frame size config page to keep it on one page, at least for my resolution.

PS I attempted to add translations for german, spanish, and french but I don't know the other languages well enough.
<3

@hqsx
Copy link

hqsx commented Sep 24, 2023

hello could u help me? why its not work for "weight"
80ff300
i made like in instuction, in 1st time when log or mb another event i can with new sllider "friendly weight" change weight for frendly nmplate, but when i relog its stoped work
(height work normaly
mb i have to add something in hook or somewhere else

@krazdord
Copy link
Author

Hi - oops, my bad. I only really cared what happened inside raid instances where you can't edit the friendly nameplates anyways, so I didn't notice it wasn't actually changing the width/height. I pushed some changes that should fix the issue, so pull and retry?
Thanks for getting back to me!

Comment on lines +387 to +393
for index, data in ipairs(f) do
print(index)

for key, value in pairs(data) do
print('\t', key, value)
end
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove these after you're done working on the PR please

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for index, data in ipairs(f) do
print(index)
for key, value in pairs(data) do
print('\t', key, value)
end
end

Would be cool if we could merge this - is anything else needed?

@krazdord
Copy link
Author

krazdord commented Nov 19, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants