Fix Liquid include tag #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to get Slim working, I found a handful of forks that each appear to make a contribution to keeping the gem operational, and this one seems the most developed. I found it works for templates and layouts, but not includes.
This PR fixes the include tag and adds some tests (which don't test the fix yet...working on that now).
I see we also have slim-template#5 which seems like a separate direction to try and resuscitate the top-most
slim-templaterepo. Not sure what the status is on that but it isn't currently working for me.Figured I'd open this up and at least have one fork fully working. Disclaimer: I'm not familiar with the Jekyll or Liquid source. Just looked at another Jekyll extension to look for patterns and applied that here.