Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feats docs(loops) : updated loop over a list of values #1888

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Adematics
Copy link
Contributor

pull request addresses issue #1744 task 2

@Ben8t
Copy link
Member

Ben8t commented Oct 22, 2024

@Adematics can you update your PR by using the ForEach task instead please ?

Since 0.18 release, a new ForEach core task has been introduced to unify and simplify parallel and sequential task executions, replacing (in a non-breaking way) the EachParallel and EachSequential tasks. Those old tasks are deprecated but you can still use them — take as much time as you need to migrate.

https://kestra.io/plugins/core/tasks/flow/io.kestra.plugin.core.flow.foreach

@Adematics
Copy link
Contributor Author

Alright then, I would check it out. @Ben8t

@wrussell1999
Copy link
Member

Hey @Adematics, did you make any progress here? Let us know if you need a hand!

@Adematics
Copy link
Contributor Author

Hello @wrussell1999 , I haven't yet updated. sorry for the delay. I will keep you updated when I do. I will get it updated before weekend.

@Adematics
Copy link
Contributor Author

Hello @wrussell1999 @Ben8t

Kindly look into the Foreach Plugin, it seem to have an issue.
I tried using the examples on the official documentation and it kept leading to invalid entity

Here is an image of the issue:

foreacherror

@wrussell1999
Copy link
Member

wrussell1999 commented Nov 6, 2024

@Adematics looks like there might be an issue with the plugins on your Kestra instance. I was able to get the same example without the error you had on the latest version of the develop image. Can you let me know what version of Kestra you're running and if you're using the no-plugins image or base one?

Screenshot 2024-11-06 at 11 06 50
Screenshot 2024-11-06 at 11 07 04

@wrussell1999
Copy link
Member

I did find an error when executing it on develop. It works on latest though for writing the guide.

@Adematics
Copy link
Contributor Author

Ok I will look into it and send any update

@Adematics
Copy link
Contributor Author

I just checked it out again, and I am still getting the same error.

This is the version I am using with docker

kestra:
      image: kestra/kestra:latest-full
      pull_policy: always
      entrypoint: /bin/bash
      # Note that this is meant for development only. Refer to the documentation for production deployments of Kestra which runs without a root user.
      user: "root"
      command:
        - -c
        - /app/kestra server standalone --worker-thread=128
      volumes:
        - kestra-data:/app/storage
        - /var/run/docker.sock:/var/run/docker.sock
        - /tmp/kestra-wd:/tmp/kestra-wd
      environment:
        KESTRA_CONFIGURATION: |
          datasources:
            postgres:
              url: jdbc:postgresql://postgres:5432/kestra
              driverClassName: org.postgresql.Driver
              username: kestra
              password: k3str4
          kestra:
            server:
              basic-auth:
                enabled: false
                username: admin
                password: kestra
            repository:
              type: postgres
            storage:
              type: minio
              minio:
                endpoint: http://minio
                port: 9000
                accessKey: admin
                secretKey: password
                region: us-east-1
                bucket: warehouse
            queue:
              type: postgres
            tasks:
              tmp-dir:
                path: /tmp/kestra-wd/tmp
            url: http://localhost:8080/
      ports:
        - "8080:8080"
        - "8081:8081"
      depends_on:
        postgres:
          condition: service_started
      networks:
        kestra_net:
        

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To review
Development

Successfully merging this pull request may close these issues.

3 participants