Annotate ServiceAccount in Helm chart and add commented-out examples in values.yaml #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-geller
reviewed
Oct 25, 2024
anna-geller
reviewed
Oct 25, 2024
| @@ -59,6 +59,29 @@ helm repo add kestra https://helm.kestra.io/ | |||
| helm install my-kestra kestra/kestra | |||
| ``` | |||
|
|
|||
| **Workload Identity Setup(Optional)** | |||
|
|
|||
| If you are using Google Cloud Workload Identity, you can annotate your Kubernetes service account in the Helm chart configuration. This will allow Kestra to automatically use the associated GCP service account for authentication. | |||
There was a problem hiding this comment.
Did you test that this works? if so, can you add a couple of screenshots?
There was a problem hiding this comment.
I haven't tested it since GKE is not free.
Co-authored-by: Anna Geller <anna.m.geller@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With reference to issue #958
it would be nice if you could annotate the serviceaccount via the helm chart rather than creating a seperate service account for workload identity
also, it would be nice if the values.yaml in git had some commented-out examples for configuration: secret: etc
@anna-geller Please have a look